WebXR Raw Camera Access (color)#5786
Merged
mvaligursky merged 15 commits intoplaycanvas:mainfrom Nov 28, 2023
Merged
Conversation
Collaborator
Author
|
There was a comment from @mvaligursky:
I've tried multiple ways:
Currently WebXR integration is only WebGL compatible, there are WebXR-WebGPU bindings Specs coming along, but we do not have devices that do support both APIs yet, so this is for the future PRs. |
mvaligursky
reviewed
Nov 23, 2023
mvaligursky
reviewed
Nov 23, 2023
mvaligursky
reviewed
Nov 23, 2023
mvaligursky
reviewed
Nov 23, 2023
Contributor
|
Fantastic PR @Maksims , thanks for this! I added few small comments, but overall this is great. |
mvaligursky
reviewed
Nov 24, 2023
mvaligursky
reviewed
Nov 24, 2023
mvaligursky
approved these changes
Nov 28, 2023
Contributor
mvaligursky
left a comment
There was a problem hiding this comment.
Great work, thanks so much.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR integrates Raw Camera Access API, that provides access to color image of a XR views. Along the way it introduces XrView concept which aligns with WebXR specs. It gives access to each view (single on mobile phones, and two on HMD devices), and will be extended with Depth Sensing API in the future. As current Depth Sensing API assumes a single view, so it will not work well with Quest 3's ability of providing depth maps for each view.
Test link: https://examples.playcanvas.meta.space/#/xr/ar-camera-color
Discussions: #5780
I confirm I have read the contributing guidelines and signed the Contributor License Agreement.